net: hns3: remove unnecessary configuration recapture while resetting
authorHuazhong Tan <tanhuazhong@huawei.com>
Tue, 18 Dec 2018 11:37:52 +0000 (19:37 +0800)
committerSalvatore Bonaccorso <carnil@debian.org>
Thu, 18 Jul 2019 22:23:17 +0000 (23:23 +0100)
When doing reset, it is unnecessary to get the hardware's default
configuration again, otherwise, the user's configuration will be
overwritten.

Fixes: 4ed340ab8f49 ("net: hns3: Add reset process in hclge_main")
Signed-off-by: Huazhong Tan <tanhuazhong@huawei.com>
Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Gbp-Pq: Topic bugfix/arm64/huawei-taishan
Gbp-Pq: Name 0017-net-hns3-remove-unnecessary-configuration-recapture-.patch

drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c

index 340baf6a470cc1889b227494eab53eca8d67d3a2..1dada183456cd00490b77eacaf0eeb094fe9db25 100644 (file)
@@ -5812,19 +5812,6 @@ static int hclge_reset_ae_dev(struct hnae3_ae_dev *ae_dev)
                return ret;
        }
 
-       ret = hclge_get_cap(hdev);
-       if (ret) {
-               dev_err(&pdev->dev, "get hw capability error, ret = %d.\n",
-                       ret);
-               return ret;
-       }
-
-       ret = hclge_configure(hdev);
-       if (ret) {
-               dev_err(&pdev->dev, "Configure dev error, ret = %d.\n", ret);
-               return ret;
-       }
-
        ret = hclge_map_tqp(hdev);
        if (ret) {
                dev_err(&pdev->dev, "Map tqp error, ret = %d.\n", ret);